Re: ECPG installcheck tests fail if PGDATABASE is set
Peter Geoghegan <pg@bowt.ie>
From: Peter Geoghegan <pg@bowt.ie>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
Michael Meskes <meskes@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-09-28T03:18:25Z
Lists: pgsql-hackers
On Fri, Sep 27, 2019 at 3:03 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Please do. > > After looking closer at the code in pg_regress.c, I'm wondering a bit > about PGSERVICE. A setting for that might certainly bring in a value > for the database name, but I don't think we can just summarily unset it. > I don't plan to do anything about that right now, but conceivably it'd > bite people someday. At least there will be some breadcrumbs to follow in the archive. > Another thing that looks a bit fishy here is that the set of variables > that pg_regress.c unsets is very much smaller than the set that libpq > reacts to --- we have added a ton of the latter without touching this > list (much less the three or four other places that duplicate it). > I wonder how problematic that is. Only time will tell, I suspect. -- Peter Geoghegan
Commits
-
Make pg_regress.c unset PGDATABASE during make installcheck.
- 5ee96b3e2221 13.0 landed