Re: cpluspluscheck complains about use of register

Peter Geoghegan <pg@bowt.ie>

From: Peter Geoghegan <pg@bowt.ie>

To: Andres Freund <andres@anarazel.de>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>

Date: 2022-09-24T19:59:30Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove uses of register due to incompatibility with C++17 and up
- 03bf971d2dc7 16.0 landed

On Sat, Sep 24, 2022 at 12:11 PM Andres Freund <andres@anarazel.de> wrote:
> I hit this again while porting cplupluscheck to be invoked by meson as
> well. ISTM that we should just remove the uses of register. Yes, some very old
> compilers might generate worse code without register, but I don't think we
> need to care about peak efficiency with neolithic compilers.

+1. I seem to recall reading that the register keyword was basically
useless as long as 15 years ago.

-- 
Peter Geoghegan