Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug

Peter Geoghegan <pg@bowt.ie>

From: Peter Geoghegan <pg@bowt.ie>

To: Andres Freund <andres@anarazel.de>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>

Date: 2019-10-29T23:42:07Z

Lists: pgsql-hackers

On Tue, Oct 29, 2019 at 4:33 PM Andres Freund <andres@anarazel.de> wrote:
> Does anybody have an opinion about fixing it just in master or also
> backpatching it? I guess there could be people having written parsers
> for the waldump output?  I'm inclined to backpatch.

The same commit from Heikki omitted one field from that record, for no
good reason. I backpatched a bugfix to the output format for nbtree
page splits a few weeks ago, fixing that problem. I agree that we
should also backpatch this bugfix.

-- 
Peter Geoghegan

Commits

pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.
- 39ff656a4151 9.5.20 landed
- bc4f56c181ae 9.6.16 landed
- 82200115e055 10.11 landed
- 3b24cf732e17 11.6 landed
- d4b5206b2237 12.1 landed
- e4d92126fda1 13.0 landed
pg_waldump: Fix small memory leak when rmgr->rm_identify returns NULL.
- e3ff8c360e4d 10.11 landed
- c3882f8b894a 9.5.20 landed
- af67aee69189 11.6 landed
- 95f2efd5041b 9.6.16 landed
- 4ab353c477e6 12.1 landed
- e0f76f204ccb 13.0 landed
Revamp the WAL record format.
- 2c03216d8311 9.5.0 cited
Improve code around the recently added rm_identify rmgr callback.
- 604f7956b946 9.5.0 cited