Horton

Re: ICU locales and text/char(n) SortSupport on Windows

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-09-22T16:25:44Z
Lists: pgsql-hackers 
On Fri, Sep 22, 2017 at 7:25 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> I agree.  The attached patch should do it.

I see one small issue here: You'll now need to set ssup->comparator
back to NULL before you return early in the Windows' libc case. That
way, a shim comparator (that goes through bttextcmp(), in the case of
text) will be installed within FinishSortSupportFunction(). Other than
that, looks good to me.

Thanks
-- 
Peter Geoghegan

Commits

  1. Assume wcstombs(), towlower(), and sibling functions are always present.