Horton

Re: new heapcheck contrib module

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-04-20T19:37:07Z
Lists: pgsql-hackers 
I mean an interface that's friendly to DBAs, that verifies an entire
database. No custom sql query required. Something that provides a
reasonable mix of verification options based on high level directives. All
verification methods can be combined in a granular, possibly randomized
fashion. Maybe we can make this run in parallel.

For example, maybe your heap checker code sometimes does index probes for a
subset of indexes and heap tuples. It's not hard to combine it with the
rootdescend stuff from amcheck. It should be composable.

The interface you've chosen is a good starting point. But let's not miss an
opportunity to make everything work together.

Peter Geoghegan
(Sent from my phone)

Commits

  1. Add pg_amcheck, a CLI for contrib/amcheck.

  2. Refactor and generalize the ParallelSlot machinery.

  3. Generalize parallel slot result handling.

  4. Move some code from src/bin/scripts to src/fe_utils to permit reuse.

  5. Factor pattern-construction logic out of processSQLNamePattern.

  6. Doc: clean up verify_heapam() documentation.

  7. Fix more portability issues in new amcheck code.

  8. Fix portability issues in new amcheck test.

  9. Try to avoid a compiler warning about using fxid uninitialized.

  10. Extend amcheck to check heap pages.

  11. Adjust walsender usage of xlogreader, simplify APIs

  12. Improve checking of child pages in contrib/amcheck.

  13. Sanitize line pointers within contrib/amcheck.

  14. Fix possible sorting error when aborting use of abbreviated keys.