Horton

Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Date: 2021-02-14T21:01:57Z
Lists: pgsql-hackers 
On Sat, Feb 6, 2021 at 7:40 PM Andres Freund <andres@anarazel.de> wrote:
> Looks like a mistake on my part... Probably a rename regex that somehow
> went wrong - I went back and forth on those names way too many
> times. Want me to push the fix?

Spotted another one: Shouldn't ReadNextFullTransactionId() actually be
called ReadNewFullTransactionId()? Actually, the inverse approach
looks like it produces fewer inconsistencies: you could instead rename
ReadNewTransactionId() to ReadNextTransactionId().

-- 
Peter Geoghegan

Commits

  1. ReadNewTransactionId() -> ReadNextTransactionId().

  2. Rename removable xid function for consistency.

  3. Add basic infrastructure for 64 bit transaction IDs.