Horton

Thread

Commits

  1. Mention REINDEX CONCURRENTLY in documentation about index maintenance

  1. "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

    Peter Geoghegan <pg@bowt.ie> — 2019-04-25T20:34:41Z

    The documentation has a section called "Routine Reindexing", which
explains how to simulate REINDEX CONCURRENTLY with a sequence of
creation and replacement steps. This should be updated to reference
the REINDEX CONCURRENTLY command.

-- 
Peter Geoghegan

  2. Re: "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

    Michael Paquier <michael@paquier.xyz> — 2019-04-26T03:05:37Z

    On Thu, Apr 25, 2019 at 01:34:41PM -0700, Peter Geoghegan wrote:
> The documentation has a section called "Routine Reindexing", which
> explains how to simulate REINDEX CONCURRENTLY with a sequence of
> creation and replacement steps. This should be updated to reference
> the REINDEX CONCURRENTLY command.

Agreed, good catch.  I would suggest to remove most of the section and
just replace it with a reference to REINDEX CONCURRENTLY, as per the
attached.  What do you think?
--
Michael

  3. Re: "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2019-04-26T12:32:15Z

    On 2019-04-26 05:05, Michael Paquier wrote:
> On Thu, Apr 25, 2019 at 01:34:41PM -0700, Peter Geoghegan wrote:
>> The documentation has a section called "Routine Reindexing", which
>> explains how to simulate REINDEX CONCURRENTLY with a sequence of
>> creation and replacement steps. This should be updated to reference
>> the REINDEX CONCURRENTLY command.
> 
> Agreed, good catch.  I would suggest to remove most of the section and
> just replace it with a reference to REINDEX CONCURRENTLY, as per the
> attached.  What do you think?

looks good to me

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  4. Re: "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

    Tom Lane <tgl@sss.pgh.pa.us> — 2019-04-26T14:53:35Z

    Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Apr 25, 2019 at 01:34:41PM -0700, Peter Geoghegan wrote:
>> The documentation has a section called "Routine Reindexing", which
>> explains how to simulate REINDEX CONCURRENTLY with a sequence of
>> creation and replacement steps. This should be updated to reference
>> the REINDEX CONCURRENTLY command.

> Agreed, good catch.  I would suggest to remove most of the section and
> just replace it with a reference to REINDEX CONCURRENTLY, as per the
> attached.  What do you think?

+1.  Maybe say "... which requires only a
<literal>SHARE UPDATE EXCLUSIVE</literal> lock."

			regards, tom lane

  5. Re: "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

    Michael Paquier <michael@paquier.xyz> — 2019-04-27T00:07:30Z

    On Fri, Apr 26, 2019 at 10:53:35AM -0400, Tom Lane wrote:
> +1.  Maybe say "... which requires only a
> <literal>SHARE UPDATE EXCLUSIVE</literal> lock."

Thanks for the review.  Committed with your suggested change.
--
Michael