Re: interval_ops shall stop using btequalimage (deduplication)

Peter Geoghegan <pg@bowt.ie>

From: Peter Geoghegan <pg@bowt.ie>

To: Noah Misch <noah@leadboat.com>

Cc: pgsql-hackers@postgresql.org

Date: 2023-10-11T04:35:45Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Dissociate btequalimage() from interval_ops, ending its deduplication.
- bf1c21c4fad0 16.1 landed
- 782be0f7124a 15.5 landed
- 6fd1dbdb21cb 13.13 landed
- 0834df90942d 14.10 landed
- 5f27b5f848a4 17.0 landed

On Tue, Oct 10, 2023 at 8:51 PM Peter Geoghegan <pg@bowt.ie> wrote:
> I don't see any reason to delay committing your fix. The issue that
> you've highlighted is exactly the kind of issue that I anticipated
> might happen at some point. This seems straightforward.

BTW, we don't need to recommend the heapallindexed option in the
release notes. Calling bt_check_index() will reliably indicate that
corruption is present when called against existing interval_ops
indexes once your fix is in. Simply having an index whose metapage's
allequalimage field is spuriously set to true will be recognized as
corruption right away. Obviously, this will be no less true with an
existing interval_ops index that happens to be completely empty.

-- 
Peter Geoghegan