Horton

Re: Logger process and "LOG: could not close client or listen socket: Bad file descriptor"

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2023-08-29T03:18:22Z
Lists: pgsql-hackers 
On Sun, Aug 27, 2023 at 5:52 PM Michael Paquier <michael@paquier.xyz> wrote:
> From what I can see, this is is a rather old issue, because
> ListenSocket[] is filled with PGINVALID_SOCKET *after* starting the
> syslogger.  It seems to me that we should just initialize the array
> before starting the syslogger, so as we don't get these incorrect
> logs?
>
> Thoughts?  Please see the attached.

Agreed, this is very annoying. I'm going to start using your patch
with the feature branch I'm working on. Hopefully that won't be
necessary for too much longer.


-- 
Peter Geoghegan

Commits

  1. Initialize ListenSocket array earlier.