Horton

Re: Concurrency bug in amcheck

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Michail Nikolaev <michail.nikolaev@gmail.com>
Date: 2020-08-01T00:23:00Z
Lists: pgsql-hackers 
On Wed, May 13, 2020 at 4:06 PM Peter Geoghegan <pg@bowt.ie> wrote:
> On Mon, May 11, 2020 at 5:56 AM Alexander Korotkov
> <a.korotkov@postgrespro.ru> wrote:
> > Thank you.  2nd patch is proposed for master and makes btree page
> > unlink remove all the items from the page being deleted.
>
> This looks good, but can we do the
> wal_consistency_checking/btree_mask() improvement, too?

You never got around to committing the second patch (or the
wal_consistency_checking stuff). Are you planning on picking it up
again?

I'm currently working on this bug fix from Michail Nikolaev:

https://postgr.es/m/CANtu0ohkR-evAWbpzJu54V8eCOtqjJyYp3PQ_SGoBTRGXWhWRw@mail.gmail.com

It would be nice if you could commit your second patch at around the
same time. It's related IMV.

Thanks
-- 
Peter Geoghegan

Commits

  1. Remove btree page items after page unlink

  2. Fix amcheck for page checks concurrent to replay of btree page deletion