Horton

Snapshot scalability patch issue

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-15T02:42:18Z
Lists: pgsql-hackers 
The call to heap_page_prune() within lazy_scan_heap() passes a bool
literal ('false') as its fourth argument. But the fourth argument is
of type TransactionId, not bool. This has been the case since the
snapshot scalability work performed by commit dc7420c2c92. Surely
something is amiss here.

I also notice some inconsistencies in the heap_page_prune() prototype
names vs the corresponding definition names. Might be worth doing
something about in passing.

-- 
Peter Geoghegan

Commits

  1. Fix heap_page_prune() parameter order confusion introduced in dc7420c2c92.

  2. snapshot scalability: Don't compute global horizons while building snapshots.