Re: Unimpressed with pg_attribute_always_inline
Peter Geoghegan <pg@bowt.ie>
From: Peter Geoghegan <pg@bowt.ie>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
Thomas Munro <thomas.munro@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-01-09T00:20:26Z
Lists: pgsql-hackers
On Mon, Jan 8, 2018 at 4:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > When I complained that always_inline inhibits debuggability, I did NOT > mean what shows up in perf reports. I'm talking about whether you can > break at, or single-step through, a function reliably and whether gdb > knows where all the variables are. In my experience, inlining hurts > both of those things, which is why I'm saying that forcing inlining > even in non-optimized builds is a bad idea. Isn't that an argument against inlining in general, rather than forcing inlining in particular? -- Peter Geoghegan
Commits
-
Improve implementation of pg_attribute_always_inline.
- 434e6e148441 11.0 landed
-
Add pg_attribute_always_inline.
- dbb3d6f0102e 11.0 cited