Horton

Re: reporting TID/table with corruption error

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-19T17:57:58Z
Lists: pgsql-hackers 
On Thu, Aug 19, 2021 at 10:49 AM Mark Dilger
<mark.dilger@enterprisedb.com> wrote:
> There was some disagreement during the development of verify_heapam on this point.  We went with the idea that the user could find and inspect the corrupt data with another tool if they had the (blockno, offnum, attnum) information.  As such, it wasn't necessary to include all the data in the output.

I find that kind of dubious. By definition you're never supposed to
see any verify_heapam errors. If you do end up seeing one, it
should be exceptional -- something that you'll learn from. High
verbosity makes a lot of sense here.


--
Peter Geoghegan

Commits

  1. Report tuple address in data-corruption error message