Re: Maintaining a list of pgindent commits for "git blame" to ignore
Peter Geoghegan <pg@bowt.ie>
From: Peter Geoghegan <pg@bowt.ie>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-18T22:46:10Z
Lists: pgsql-hackers
On Thu, Mar 18, 2021 at 3:39 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > I don't object to maintaining such a file; if it makes "git blame" > work better, that's a huge win. However, the file as you have it > seems rather unreadable. I'd much rather have something that includes > the commit date and/or first line of commit message. Is there any > flexibility in the format, or does git blame insist it be just like this? I ended up doing it that way because I was in a hurry to see how much it helped. I can fix it up. We could require (but not automatically enforce) that the first line of the commit message be included above each hash, as a comment. You could also require reverse chronological ordering of commits. That would make everything easy to follow. It's worth noting that git insists that you provide the full hash of commits here. This is not something I remember it insisting upon in any other area. There is probably a very good practical reason for that. -- Peter Geoghegan
Commits
-
Add list of ignorable pgindent commits for git-blame.
- 8e638845ff6b 14.0 landed
-
pgindent run prior to branching v13.
- b5d69b7c22ee 13.0 cited