Horton

Re: Binary support for pgoutput plugin

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dave Cramer <davecramer@gmail.com>, Andres Freund <andres@anarazel.de>, Daniel Gustafsson <daniel@yesql.se>, Petr Jelinek <petr@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, Dmitry Dolgov <9erthalion6@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Petr Jelinek <petr.jelinek@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-07-20T15:17:25Z
Lists: pgsql-hackers 
On Sat, Jul 18, 2020 at 9:53 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I've pushed this patch, with a number of adjustments, some cosmetic
> and some not so much (no pg_dump support!?).  We're not quite
> done though ...

Skink's latest run reports a failure that I surmise was caused by this patch:

==722318== VALGRINDERROR-BEGIN
==722318== Invalid read of size 1
==722318==    at 0x4F4CC9: apply_handle_update (worker.c:834)
==722318==    by 0x4F4F81: apply_dispatch (worker.c:1427)
==722318==    by 0x4F5104: LogicalRepApplyLoop (worker.c:1635)
==722318==    by 0x4F57BF: ApplyWorkerMain (worker.c:2141)
==722318==    by 0x4BD49E: StartBackgroundWorker (bgworker.c:813)
==722318==    by 0x4CBAB4: do_start_bgworker (postmaster.c:5865)
==722318==    by 0x4CBBF5: maybe_start_bgworkers (postmaster.c:6091)
==722318==    by 0x4CC4BF: sigusr1_handler (postmaster.c:5260)
==722318==    by 0x486413F: ??? (in
/usr/lib/x86_64-linux-gnu/libpthread-2.31.so)
==722318==    by 0x4DC7845: select (select.c:41)
==722318==    by 0x4CCE40: ServerLoop (postmaster.c:1691)
==722318==    by 0x4CE106: PostmasterMain (postmaster.c:1400)
==722318==  Address 0x78cb0ab is 443 bytes inside a recently
re-allocated block of size 8,192 alloc'd
==722318==    at 0x483877F: malloc (vg_replace_malloc.c:307)
==722318==    by 0x6A55BD: AllocSetContextCreateInternal (aset.c:468)
==722318==    by 0x280262: AtStart_Memory (xact.c:1108)
==722318==    by 0x2806ED: StartTransaction (xact.c:1979)
==722318==    by 0x282128: StartTransactionCommand (xact.c:2829)
==722318==    by 0x4F5514: ApplyWorkerMain (worker.c:2014)
==722318==    by 0x4BD49E: StartBackgroundWorker (bgworker.c:813)
==722318==    by 0x4CBAB4: do_start_bgworker (postmaster.c:5865)
==722318==    by 0x4CBBF5: maybe_start_bgworkers (postmaster.c:6091)
==722318==    by 0x4CC4BF: sigusr1_handler (postmaster.c:5260)
==722318==    by 0x486413F: ??? (in
/usr/lib/x86_64-linux-gnu/libpthread-2.31.so)
==722318==    by 0x4DC7845: select (select.c:41)
==722318==
==722318== VALGRINDERROR-END

See https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2020-07-20%2002%3A37%3A51

-- 
Peter Geoghegan

Commits

  1. Weaken type-OID-matching checks in array_recv and record_recv.

  2. Fix construction of updated-columns bitmap in logical replication.

  3. Allow logical replication to transfer data in binary format.

  4. Phase 2 pgindent run for v12.