Horton

Re: BUG #19102: Assertion failure in generate_orderedappend_paths with aggregate pushdown

Kuntal Ghosh <kuntalghosh.2007@gmail.com>

View thread
From: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org, akorotkov@postgresql.org
Date: 2025-11-04T09:51:56Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix assertion failure in generate_orderedappend_paths()

  2. Avoid creating duplicate ordered append paths

On Tue, Nov 4, 2025 at 1:14 PM Richard Guo <guofenglinux@gmail.com> wrote:

> Here are the updated patches.  I split the changes into two: 0001
> fixes the Assert failure and updates the out-of-date comment for
> generate_orderedappend_paths(), while 0002 addresses the second and
> third issues I described upthread.
>
> The assertion failure also exists in v18, so I think it would be best
> to get 0001 pushed and backpatched before the code freeze.  I'm not
> sure whether 0002 should be backpatched.  Before that, I'd like to
> know whether these two patches make sense.
>
Thanks for the patch.

The fix for the assert failure looks good to me. And, yes, it would be good
to backpatch this before the code freeze.

-- 
Thanks & Regards,
Kuntal Ghosh