Re: SLRU statistics

Kuntal Ghosh <kuntalghosh.2007@gmail.com>

From: Kuntal Ghosh <kuntalghosh.2007@gmail.com>

To: Tomas Vondra <tomas.vondra@2ndquadrant.com>

Cc: "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi.shinoda@hpe.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2020-04-07T11:31:37Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix async.c to not register any SLRU stats counts in the postmaster.
- 7fd89f4d7a51 13.0 landed
Use proper GetDatum function in pg_stat_get_slru().
- 043e3e040160 13.0 landed
Initialize SLRU stats entries to zero.
- f3d23d83ef9a 13.0 landed
Remove pg_xact from pg_stat_reset_slru docs
- e685ca63ca4f 13.0 landed
Remove pg_xact entry from SLRU stats
- 2e08d314ed07 13.0 landed
Track SLRU page hits in SimpleLruReadPage_ReadOnly
- 2b88fdde30d8 13.0 landed
Fix typo in SLRU stats documentation
- 2c220ca46f3f 13.0 landed
Collect statistics about SLRU caches
- 28cac71bd368 13.0 landed
Simplify and rename some GUC variables, per various recent discussions:
- 48f7e6439568 8.3.0 cited

Attachments

v1-0001-Update-stats-in-SimpleLruReadPage_ReadOnly.patch (application/octet-stream) patch v1-0001

Hello Tomas,

On Thu, Apr 2, 2020 at 5:59 PM Tomas Vondra
<tomas.vondra@2ndquadrant.com> wrote:
> Thank you for the patch, pushed.
>
In SimpleLruReadPage_ReadOnly, we first try to find the SLRU page in
shared buffer under shared lock, then conditionally visit
SimpleLruReadPage if reading is necessary. IMHO, we should update
hit_count if we can find the buffer in SimpleLruReadPage_ReadOnly
directly. Am I missing something?

Attached a patch for the same.

-- 
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com