Horton

Re: Custom reloptions and lock modes

Kuntal Ghosh <kuntalghosh.2007@gmail.com>

View thread View on postgr.es
From: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Nikolay Shaplov <dhyan@nataraj.su>
Date: 2019-09-20T07:10:51Z
Lists: pgsql-hackers 
On Fri, Sep 20, 2019 at 12:38 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> > One small thing:
> >
> >   add_int_reloption(bl_relopt_kind, buf,
> >    "Number of bits generated for each index column",
> > -  DEFAULT_BLOOM_BITS, 1, MAX_BLOOM_BITS);
> > +  DEFAULT_BLOOM_BITS, 1, MAX_BLOOM_BITS,
> > +  AccessExclusiveLock);
> > Do we need a comment to explain why we're using AccessExclusiveLock in
> > this case?
>
> Because that's the safest default to use here?  That seemed obvious to
> me.
Okay. Sounds good.



-- 
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Allow definition of lock mode for custom reloptions

  2. Fix failure with lock mode used for custom relation options