Horton

Re: Doc: add XML ID attributes to <varlistentry> tags for create_foreign_table, alter_foreign_table

wenhui qiu <qiuwenhuifx@gmail.com>

View thread
From: wenhui qiu <qiuwenhuifx@gmail.com>
To: Quan Zongliang <quanzongliang@yeah.net>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-11-13T02:46:44Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Add link targets to CREATE/ALTER FOREIGN TABLE reference pages

  2. Doc: add XML ID attributes to <sectN> and <varlistentry> tags.

Hi
> Since no more suggestions have been provided. And this is a very minor
> change. Although there are currently no other documents linked to these
> tags. This patch makes this document more complete and in line with
> conventions of other similar documents. So I changed it to "Ready for
>  Committer"
Agree +1

Thanks

On Thu, Nov 13, 2025 at 10:20 AM Quan Zongliang <quanzongliang@yeah.net>
wrote:

>
>
> On 9/22/25 9:27 AM, Quan Zongliang wrote:
> >
> >
> > On 9/19/25 11:08 AM, jian he wrote:
> >> hi.
> >>
> >> with commit like:
> >> https://git.postgresql.org/cgit/postgresql.git/commit/?
> >> id=78ee60ed84bb3a1cf0b6bd9a715dcbcf252a90f5
> >>
> >> we can make a url link that points directly to a specific subsection
> >> of the document.
> >> for example:
> >> https://www.postgresql.org/docs/devel/sql-createtable.html#SQL-
> >> CREATETABLE-PARMS-LIKE-OPT-COMMENTS
> >> will link to exactly the CREATE TABLE LIKE INCLUDING COMMENTS section.
> >>
> >> The attached patch adds XML ID attributes to <varlistentry> tags for
> >> create_foreign_table.sgml,
> >> and alter_foreign_table.sgml.
> >> While working on CREATE TABLE LIKE, I happened to find this issue.
> >> Maybe we can have a way to automate all <varlistentry>, but there are
> >> so many <varlistentry>.
> >
> > LGTM
> >
> > And I tested this patch on macOS Intel.
> >
> Since no more suggestions have been provided. And this is a very minor
> change. Although there are currently no other documents linked to these
> tags. This patch makes this document more complete and in line with
> conventions of other similar documents. So I changed it to "Ready for
> Committer"
>
> > --
> > Quan Zongliang
> >
> >
>
>
>
>