Horton

Re: Vectorize pg_visibility.pg_visibility_map_summary

wenhui qiu <qiuwenhuifx@gmail.com>

View thread
From: wenhui qiu <qiuwenhuifx@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>, Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-23T04:03:31Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_visibility: Use visibilitymap_count instead of loop.

Hi

> It looks like a reasonable idea as it also simplifies the
> pg_visibility_map_summary() function. I'm going to push it, barring
> any objections.
Obviously no objections, Using visibilitymap_count() simplifies the code
and improves performance, with no behavior change.

Thanks

On Tue, Dec 23, 2025 at 6:17 AM Matthias van de Meent <
boekewurm+postgres@gmail.com> wrote:

> Hi,
>
> On Mon, 22 Dec 2025 at 23:04, Masahiko Sawada <sawada.mshk@gmail.com>
> wrote:
> > On Mon, Dec 22, 2025 at 1:28 PM Matthias van de Meent
> > <boekewurm+postgres@gmail.com> wrote:
> > > Here's one small patch that makes it use the visibilitymap_count() API
> > > for pg_visibility_map_summary(), replacing its own bespoke counting
> > > mechanism with the primary implementation that has vectorized
> > > optimizations, thus reducing the overhead of
> > > pg_visibility_map_summary.
> > >
> >
> > It looks like a reasonable idea as it also simplifies the
> > pg_visibility_map_summary() function. I'm going to push it, barring
> > any objections.
>
> Obviously no objections from me, and, thanks!
>
>
> Kind regards,
>
> Matthias van de Meent
> Databricks (https://www.databricks.com)
>
>
>