Re: Small optimization with expanding dynamic hash table
wenhui qiu <qiuwenhuifx@gmail.com>
From: wenhui qiu <qiuwenhuifx@gmail.com>
To: cca5507 <cca5507@qq.com>
Cc: Rahila Syed <rahilasyed90@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-11T09:33:52Z
Lists: pgsql-hackers
Hi > The v2 patch maybe more clear: > We can calc bucket just by hashvalue & high_mask when expanding table because the if condition in calc_bucket() must be false. I think you may add a comment to this path so that code reviewers can clearly see your optimization. Thanks On Thu, Jul 10, 2025 at 10:46 AM cca5507 <cca5507@qq.com> wrote: > Hi, > > The v2 patch maybe more clear: > > We can calc bucket just by hashvalue & high_mask when expanding table > because the if condition in calc_bucket() must be false. > > -- > Regards, > ChangAo Chen > >