Horton

Re: [PATCH] Refactor: Extract XLogRecord info

wenhui qiu <qiuwenhuifx@gmail.com>

View thread
From: wenhui qiu <qiuwenhuifx@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fabrízio de Royes Mello <fabriziomello@gmail.com>, Steven Niu <niushiji@gmail.com>, Xiaoran Wang <fanfuxiaoran@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-06-10T08:00:29Z
Lists: pgsql-hackers 
HI
> FWIW, I'm not sure what's the benefit of the proposal which comes down
> to the removal of a bitwise NOT, except more code conflicts with back
> branches.
Agree

On Tue, Jun 10, 2025 at 3:37 PM Michael Paquier <michael@paquier.xyz> wrote:

> On Mon, Jun 09, 2025 at 10:54:43PM -0300, Fabrízio de Royes Mello wrote:
> > The refactoring LGTM but do we really need two patches? IMHO you can just
> > merge everything into a single patch.
>
> FWIW, I'm not sure what's the benefit of the proposal which comes down
> to the removal of a bitwise NOT, except more code conflicts with back
> branches.
> --
> Michael
>