Re: New standby_slot_names GUC in PG 17
Muhammad Ikram <mmikram@gmail.com>
From: Muhammad Ikram <mmikram@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-06-21T19:13:08Z
Lists: pgsql-hackers
Hi, A humble input, as on primary we have #primary_slot_name = '' then should not it be okay to have standby_slot_names or standby_slot_name ? It seems consistent with the Guc on primary. Another suggestion is *standby_replication_slots*. Regards, Muhammad Ikram Bitnine Global. On Fri, Jun 21, 2024 at 8:47 PM Nathan Bossart <nathandbossart@gmail.com> wrote: > On Fri, Jun 21, 2024 at 11:37:54AM -0400, Bruce Momjian wrote: > > The release notes have this item: > > > > Allow specification of physical standbys that must be synchronized > > before they are visible to subscribers (Hou Zhijie, Shveta Malik) > > > > The new server variable is standby_slot_names. > > > > Is standby_slot_names an accurate name for this GUC? It seems too > > generic. > > +1, I was considering bringing this up, too. I'm still thinking of > alternate names to propose, though. > > -- > nathan > > > -- Muhammad Ikram
Commits
-
Update release notes to reflect recent commit 0f934b0739.
- 58c5f60eb8ce 17.0 landed
-
Rename standby_slot_names to synchronized_standby_slots.
- 2357c9223b71 18.0 landed
- 0f934b0739ad 17.0 landed
-
Add a new slot sync worker to synchronize logical slots.
- 93db6cbda037 17.0 cited