Re: [PATCH] Expand character set for ltree labels
Garen Torikian <gjtorikian@gmail.com>
From: Garen Torikian <gjtorikian@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2023-01-03T18:56:49Z
Lists: pgsql-hackers
Attachments
- 0003-Expand-character-set-for-ltree-labels.patch (application/octet-stream) patch 0003
Sure. Rebased onto HEAD. On Tue, Jan 3, 2023 at 7:27 AM vignesh C <vignesh21@gmail.com> wrote: > On Thu, 6 Oct 2022 at 03:35, Garen Torikian <gjtorikian@gmail.com> wrote: > > > > After digging into it, you are completely correct. I had to do a bit > more reading to understand the relationships between UTF-8 and wchar, but > ultimately the existing locale support works for my use case. > > > > Therefore I have updated the patch with three much smaller changes: > > > > * Support for `-` in addition to `_` > > * Expanding the limit to 512 chars (from the existing 256); again it's > not uncommon for non-English strings to be much longer > > * Fixed the documentation to expand on what the ltree label's > relationship to the DB locale is > > The patch does not apply on top of HEAD as in [1], please post a rebased > patch: > === Applying patches on top of PostgreSQL commit ID > e351f85418313e97c203c73181757a007dfda6d0 === > === applying patch ./0002-Expand-character-set-for-ltree-labels.patch > patching file contrib/ltree/expected/ltree.out > patching file contrib/ltree/ltree.h > Hunk #2 FAILED at 126. > 1 out of 2 hunks FAILED -- saving rejects to file contrib/ltree/ltree.h.rej > > [1] - http://cfbot.cputube.org/patch_41_3929.log > > Regards, > Vignesh >
Commits
-
Allow hyphens in ltree labels
- b1665bf01e5f 16.0 landed
-
Check that xmax didn't commit in freeze check.
- eb5ad4ff05fd 16.0 cited
-
Push lpp variable closer to usage in heapgetpage()
- e351f8541831 16.0 cited
-
tests: Restrict pg_locks queries in advisory_locks.sql to current database
- c3315a7da57b 16.0 cited