Re: Resetting recovery target parameters in pg_createsubscriber

Alena Vinter <dlaaren8@gmail.com>

From: Alena Vinter <dlaaren8@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Alexander Korotkov <aekorotkov@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2025-09-29T09:57:09Z

Lists: pgsql-hackers

Attachments

v6-0001-Implements-helper-function-in-recovery_gen.patch (text/x-patch)
v6-0003-doc-Add-warning-about-leftover-recovery-parameters-i.patch (text/x-patch)
v6-0002-Reseting-recovery-target-parameters-in-pg_createsubs.patch (text/x-patch)

Hi,

> In short, I disagree with what you are doing here: we should take the
> extra step and clean up anything that's been created by the tool when
> we know we can safely do so

I got your point, thanks for pointing to the `pg_rewind` case. I've
attached a new version of the patches. I've changed `ReplaceRecoveryConfig`
a little bit -- now it returns false in case of an error instead of exiting.

Best wishes,
Alena Vinter