Resetting recovery target parameters in pg_createsubscriber
Alena Vinter <dlaaren8@gmail.com>
From: D Laaren <dlaaren8@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Date: 2025-07-16T05:57:18Z
Lists: pgsql-hackers
Attachments
- v1-0001-TAP-test-recovery_fails_after_pg_createsubscriber.pl (application/x-perl)
- v1-0002-reset-recovery-target-params-pg-createsubscriber.patch (text/x-patch)
Hi Hackers, I noticed that pg_createsubscriber sets recovery target params for correct recovery before converting a physical replica to a logical one but does not reset them afterward. It can lead to recovery failures in certain scenarios. For example, if recovery begins from a checkpoint where no WAL records need to be applied, the system might incorrectly determine that the recovery target was never reached because these parameters remain active. I’ve attached a TAP test to reproduce the issue. The proposed patch ensures all recovery parameters are reset after conversion to prevent such edge cases. I would appreciate any feedback. -- Regards, Alyona Vinter