Thread

Re: Resetting recovery target parameters in pg_createsubscriber

Alena Vinter <dlaaren8@gmail.com> — 2025-09-08T04:07:22Z

Hi,

CFbot indicated some issues with the patch. I've attached rebased versions
of the patches, so hopefully everything will be ok this time.

Best regards,
Alyona Vinter

On Fri, 5 Sept 2025 at 12:51, Alyona Vinter <dlaaren8@gmail.com> wrote:

> Dear Hayato,
>
> Thank you for the review! My apologies for the error in the patch -- it
> looks like I accidentally modified it before sending =(. I've attached the
> fixed versions below.
>
> > Regarding patch content, your patch restores the postgresql.auto.conf
> after the
> > command runs. Initially I felt that it is enough to set below GUCs
> becasue only
> > they are changed from the default. Is there a reason why you fully
> restore them?
>
> I just found it easier to restore the original state of
> 'postgresql.auto.conf', as removing parameters from the file resets them to
> their default values. This approach achieves the same final state without
> having to explicitly set each one.
>