Re: PG 18 beta1 release notes misses mention of pg_noreturn
Steve Chavez <steve@supabase.io>
From: Steve Chavez <steve@supabase.io>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-07-03T14:38:26Z
Lists: pgsql-hackers
Yes, otherwise I had to grep the commits in `git log` and find what's the correct way to use `pg_noreturn`. It's not a simple keyword replacement since the order has to change now: Old: void my_worker(Datum main_arg) pg_attribute_noreturn(); New: pg_noreturn void my_worker(Datum main_arg); I've added the link to the commit in the patch, which should be enough to infer the above. How can I get this committed? Is the hacker mailing list the right place for release notes correction? Best regards, Steve Chavez On Wed, 2 Jul 2025 at 11:24, Daniel Gustafsson <daniel@yesql.se> wrote: > > On 2 Jul 2025, at 04:51, Steve Chavez <steve@supabase.io> wrote: > > > While updating an extension to support 18beta1, I stumbled on the > removal of `pg_attribute_noreturn()` in favor of `pg_noreturn`, which > wasn't mentioned in the release notes. > > That admittedly seems like something worth including since it's otherwise > not > documented anywhere. > > -- > Daniel Gustafsson > >