Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
shihao zhong <zhong950419@gmail.com>
From: shihao zhong <zhong950419@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-11-01T02:30:33Z
Lists: pgsql-hackers
Attachments
- update_document_exclude_with_collate_v2.patch (application/octet-stream) patch v2
On Tue, Oct 31, 2023 at 9:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > shihao zhong <zhong950419@gmail.com> writes: > > I noticed that the CREATE/ALTER TABLE document does not mention that > > EXCLUDE can accept a collation. I created a documentation fix for this > > issue, and I have attached it to this email. > > > Hmm ... is this actually correct? I think that the collate > > option has to come before the opclass name etc, so you'd need > > to shove it into exclude_element to provide an accurate > > description of the syntax. > > > > regards, tom lane > Hi Tom, Thank you for your feedback on my previous patch. I have fixed the issue and attached a new patch for your review. Could you please take a look for it if you have a sec? Thanks Also, if I understand correctly, the changes to sql_help.c will be made by the committer, so I do not need to run create_help.pl in my patch. Can you please confirm? I appreciate your help and time. Thanks, Shihao
Commits
-
Doc: update documentation about EXCLUDE constraint elements.
- 1973d9fb3183 17.0 landed
- e2663a63c3b9 15.7 landed
- a690920015bd 16.3 landed
- 7a0541301078 14.12 landed
- 5fe7bcc6766b 13.15 landed