Re: Add missing stats_reset column to pg_stat_database_conflicts view
shihao zhong <zhong950419@gmail.com>
From: shihao zhong <zhong950419@gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Sami Imseih <samimseih@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-03-10T18:43:19Z
Lists: pgsql-hackers
Attachments
- pg_stat_database_conflicts_v2.patch (application/octet-stream) patch v2
The patch has been rebased, and the documentation and catversion updates have been added. > I also noticed that pg_statio_all_sequences does not have a reset > column. We should fix this one also. What do you think? Right now the pg_statio_all_tables, pg_statio_all_indexes, pg_statio_all_sequences, pg_stat_user_functions all do not have reset_stat supported. I am actively working on tadd a reset_stat support for these view. For now, let's quickly address the db conflict first. On Tue, Mar 10, 2026 at 7:32 AM Kirill Reshke <reshkekirill@gmail.com> wrote: > > On Tue, 10 Mar 2026 at 06:17, Fujii Masao <masao.fujii@gmail.com> wrote: > > > > On Tue, Mar 10, 2026 at 8:33 AM Sami Imseih <samimseih@gmail.com> wrote: > > > > > > > The attached patch adds pg_stat_get_db_stat_reset_time() to fix this > > > > inconsistency. > > > > > > > > Please let me know your thoughts. > > > > > > This view was introduced 15 years ago, and surprisingly this is the > > > first complaint about this. I am also not very surprised. > > > > > > I also noticed that pg_statio_all_sequences does not have a reset > > > column. We should fix this one also. What do you think? > > > > +1 > > > > Also it might be better to update the docs together so that the description of > > pg_stat_reset_single_table_counters mentions sequences in addition to > > tables and indexes. > > > > Regards, > > > > -- > > Fujii Masao > > > > Well, it looks like there are not so many users of this view. Anyway, > +1 on change. > This also need catversion bump > > -- > Best regards, > Kirill Reshke
Commits
-
Simplify redundant current_database() subqueries in stats.sql regression test
- d78a4f0bf058 19 (unreleased) landed
-
Add stats_reset column to pg_stat_database_conflicts.
- 723619eaa3a8 19 (unreleased) landed