Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS

On Wed, 6 Jan 2021 at 18:23, Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:

> On 2021-01-06 00:30, Craig Ringer wrote:
> > Perhaps debug_invalidate_system_caches_always ? It's a bit long but we
> > use the debug prefix elsewhere too.
>
> Committed with that name.
>

Thanks very much.


> In your original patch, this hunk in pg_config_manual.h:
>
> + * You can define these by editing pg_config_manual.h but it's usually
> + * sufficient to pass CFLAGS to configure, e.g.
> + *
> + *     ./configure --enable-debug --enable-cassert CFLAGS="-DUSE_VALGRIND"
> + *
> + * The flags are persisted in Makefile.global so they will be correctly
> + * applied to extensions, including those built by PGXS.
>
> I don't think that necessarily works for all settings.  Maybe we should
> make a pass through it and ensure it all works sensibly, but that seems
> like a separate project.
>

It should work for everything, since we persist the CFLAGS string, rather
than individual settings.

But I didn't mean to leave that in the same patch anyway, it's separate.