Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE

Melih Mutlu <m.melihmutlu@gmail.com>

From: Melih Mutlu <m.melihmutlu@gmail.com>

To: vignesh C <vignesh21@gmail.com>

Cc: Michael Paquier <michael@paquier.xyz>, Dong Wook Lee <sh95119@gmail.com>, pgsql-hackers@postgresql.org

Date: 2022-12-06T15:12:38Z

Lists: pgsql-hackers

Hi Vignesh,

Looks like the patch needs a rebase.

Also one little suggestion:

+ if (ends_with(prev_wd, ')'))
> + COMPLETE_WITH(Alter_routine_options, "CALLED ON NULL INPUT",
> +  "RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT");


What do you think about gathering FUNCTION options as you did with ROUTINE
options.
Something like the following would seem nicer, I think.

#define Alter_function_options \
> Alter_routine_options, "CALLED ON NULL INPUT", \

"RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT"


Best,
--
Melih Mutlu
Microsoft

Commits

Fix tab completion of ALTER FUNCTION/PROCEDURE/ROUTINE ... SET SCHEMA.
- e7a59094b36a 16.0 landed
- 2daf4664ce54 15.2 landed
- 48599a18d079 14.7 landed
- 2ad4abedfeec 13.10 landed
- 274185d116f4 12.14 landed
- c54b88870081 11.19 landed
Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE.
- a3bc631ea96a 16.0 landed