Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

Melih Mutlu <m.melihmutlu@gmail.com>

From: Melih Mutlu <m.melihmutlu@gmail.com>

To: Peter Smith <smithpb2250@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Melanie Plageman <melanieplageman@gmail.com>, "Wei Wang (Fujitsu)" <wangw.fnst@fujitsu.com>, "Yu Shi (Fujitsu)" <shiy.fnst@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, shveta malik <shveta.malik@gmail.com>

Date: 2023-07-18T09:03:38Z

Lists: pgsql-hackers

Attachments

v20-0001-Refactor-to-split-Apply-and-Tablesync-Workers.patch (application/octet-stream) patch v20-0001
v20-0002-Reuse-Tablesync-Workers.patch (application/octet-stream) patch v20-0002
v20-0003-Reuse-connection-when-tablesync-workers-change-t.patch (application/octet-stream) patch v20-0003
v20-0004-Add-replication-protocol-cmd-to-create-a-snapsho.patch (application/octet-stream) patch v20-0004
v20-0005-Reuse-Replication-Slot-and-Origin-in-Tablesync.patch (application/octet-stream) patch v20-0005

Hi Peter,

Peter Smith <smithpb2250@gmail.com>, 18 Tem 2023 Sal, 04:33 tarihinde şunu
yazdı:

> On Tue, Jul 18, 2023 at 11:25 AM Peter Smith <smithpb2250@gmail.com>
> wrote:
> >
> > On Tue, Jul 18, 2023 at 1:54 AM Melih Mutlu <m.melihmutlu@gmail.com>
> wrote:
> > >
> > > Hi,
> > >
> > > PFA updated patches. Rebased 0003 with minor changes. Addressed
> Peter's reviews for 0001 and 0002 with some small comments below.
> > >
> >
> > Thanks, I will take another look at these soon. FYI, the 0001 patch
> > does not apply cleanly. It needs to be rebased again because
> > get_worker_name() function was recently removed from HEAD.
> >
>
> Sorry, to be more correct -- it applied OK, but failed to build.
>

Attached the fixed patchset.

Thanks,
-- 
Melih Mutlu
Microsoft

Commits

Refactor to split Apply and Tablesync Workers code.
- 02c1b64fb15c 17.0 landed
Fix possible logical replication crash.
- e7e7da2f8d57 16.0 cited