Re: Parent/child context relation in pg_get_backend_memory_contexts()
Melih Mutlu <m.melihmutlu@gmail.com>
From: Melih Mutlu <m.melihmutlu@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: torikoshia <torikoshia@oss.nttdata.com>,
Andres Freund <andres@anarazel.de>, Stephen Frost <sfrost@snowman.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-04-03T13:20:39Z
Lists: pgsql-hackers
Hi, Michael Paquier <michael@paquier.xyz>, 14 Şub 2024 Çar, 10:23 tarihinde şunu yazdı: > On Fri, Jan 19, 2024 at 05:41:45PM +0900, torikoshia wrote: > > We already have additional description below the table which explains > each > > column of the system view. For example pg_locks: > > https://www.postgresql.org/docs/devel/view-pg-locks.html > > I was reading the patch, and using int[] as a representation of the > path of context IDs up to the top-most parent looks a bit strange to > me, with the relationship between each parent -> child being > preserved, visibly, based on the order of the elements in this array > made of temporary IDs compiled on-the-fly during the function > execution. Am I the only one finding that a bit strange? Could it be > better to use a different data type for this path and perhaps switch > to the names of the contexts involved? > Do you find having the path column strange all together? Or only using temporary IDs to generate that column? The reason why I avoid using context names is because there can be multiple contexts with the same name. This makes it difficult to figure out which context, among those with that particular name, is actually included in the path. I couldn't find any other information that is unique to each context. Thanks, -- Melih Mutlu Microsoft
Commits
-
Add missing pointer dereference in pg_backend_memory_contexts view
- da87dc07f16e 18.0 landed
-
Add path column to pg_backend_memory_contexts view
- 32d3ed8165f8 18.0 landed
-
Allow memory contexts to have both fixed and variable ident strings.
- 442accc3fe0c 11.0 cited