Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Oliver Ford <ojford@gmail.com>

From: Oliver Ford <ojford@gmail.com>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: Krasiyan Andreev <krasiyan@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Vik Fearing <vik@postgresfriends.org>, Pg Hackers <pgsql-hackers@postgresql.org>, andrew@tao11.riddles.org.uk, David Fetter <david@fetter.org>
Date: 2025-03-13T07:49:03Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix coding style with "else".

  2. Fix multi WinGetFuncArgInFrame/Partition calls with IGNORE NULLS.

  3. Fix Coverity issue reported in commit 2273fa32bce.

  4. Use ereport rather than elog in WinCheckAndInitializeNullTreatment.

  5. Avoid uninitialized-variable warnings from older compilers.

  6. Fix Coverity issues reported in commit 25a30bbd423.

  7. Improve EXPLAIN's display of window functions.

  8. Automatically generate node support functions

Attachments

On Sun, 9 Mar 2025, 20:07 Oliver Ford, <ojford@gmail.com> wrote:

> On Sun, Mar 9, 2025 at 6:40 AM Tatsuo Ishii <ishii@postgresql.org> wrote:
>
>> > Attached version removes the non-nulls array. That seems to speed
>> > everything up.  Running the above query with 1 million rows averages
>> 450ms,
>> > similar when using lead/lag.
>>
>> Great. However, CFbot complains about the patch:
>>
>> https://cirrus-ci.com/task/6364194477441024
>>
>>
> Attached fixes the headerscheck locally.
>

v11 attached because the previous version was broken by commit 8b1b342

>