Horton

Thread

Commits

  1. doc: Update partitioning limitation on BEFORE triggers

  1. Update limitations for declarative partitioning

    Erwin Brandstetter <brsaweda@gmail.com> — 2020-08-08T02:16:04Z

    The release notes for pg 13 advertise a new feature in
https://www.postgresql.org/docs/13/release-13.html#DDL-PARTITION-PRUNING

-
>
> Allow BEFORE row-level triggers
> <https://www.postgresql.org/docs/13/triggers.html> on partitioned tables
> (Álvaro Herrera)
>
> These triggers cannot change which partition is the destination.
>
- But the manual still warns at
https://www.postgresql.org/docs/13/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS

BEFORE ROW triggers, if necessary, must be defined on individual
> partitions, not the partitioned table.
>

Looks like that "limitation" can go now? Or reduced to something like:

"BEFORE ROW triggers on the partitioned table cannot change which partition
is the destination."

Regards
Erwin

  2. Re: Update limitations for declarative partitioning

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2020-08-08T03:38:19Z

    On 2020-Aug-08, Erwin Brandstetter wrote:

> - But the manual still warns at
> https://www.postgresql.org/docs/13/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS
> 
> BEFORE ROW triggers, if necessary, must be defined on individual
> > partitions, not the partitioned table.
> >
> 
> Looks like that "limitation" can go now? Or reduced to something like:
> 
> "BEFORE ROW triggers on the partitioned table cannot change which partition
> is the destination."

Oh, right, I'll patch that up tomorrow.  Thanks for pointing it out.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  3. Re: Update limitations for declarative partitioning

    Erwin Brandstetter <brsaweda@gmail.com> — 2020-08-30T21:39:59Z

    Looking at
https://www.postgresql.org/docs/devel/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS
... the issue seems unchanged?

Regards
Erwin



On Sat, 8 Aug 2020 at 05:38, Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

> On 2020-Aug-08, Erwin Brandstetter wrote:
>
> > - But the manual still warns at
> >
> https://www.postgresql.org/docs/13/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS
> >
> > BEFORE ROW triggers, if necessary, must be defined on individual
> > > partitions, not the partitioned table.
> > >
> >
> > Looks like that "limitation" can go now? Or reduced to something like:
> >
> > "BEFORE ROW triggers on the partitioned table cannot change which
> partition
> > is the destination."
>
> Oh, right, I'll patch that up tomorrow.  Thanks for pointing it out.
>
> --
> Álvaro Herrera                https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

  4. Re: Update limitations for declarative partitioning

    Michael Paquier <michael@paquier.xyz> — 2020-08-31T02:18:55Z

    On Sun, Aug 30, 2020 at 11:39:59PM +0200, Erwin Brandstetter wrote:
> Looking at
> https://www.postgresql.org/docs/devel/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-LIMITATIONS
> ... the issue seems unchanged?

Indeed, there is no fix in the code tree.  Alvaro?  If there is no
update, I'll go fix that myself.
--
Michael

  5. Re: Update limitations for declarative partitioning

    Michael Paquier <michael@paquier.xyz> — 2020-09-01T03:01:36Z

    On Mon, Aug 31, 2020 at 11:18:55AM +0900, Michael Paquier wrote:
> Indeed, there is no fix in the code tree.  Alvaro?  If there is no
> update, I'll go fix that myself.

For the archives: this has been done with 97dc0d1.

(Thanks, Alvaro!)
--
Michael