Re: Printing LSN made easy
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
From: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>,
Craig Ringer <craig.ringer@enterprisedb.com>
Date: 2021-01-21T10:30:14Z
Lists: pgsql-hackers
On Thu, Jan 21, 2021 at 3:53 PM Peter Eisentraut < peter.eisentraut@2ndquadrant.com> wrote: > On 2021-01-20 08:50, Ashutosh Bapat wrote: > > Thanks for looking into this. I would like to keep both the LSN_FORMAT > > and LSN_FORMAT_ARGS but with a note that the first can not be used in > > elog() or in messages which require localization. We have many other > > places doing snprintf() and such stuff, which can use LSN_FORMAT. If we > > do so, the functions to output string representation will not be needed > > so they can be removed. > > Then you'd end up with half the code doing this and half the code doing > that. That doesn't sound very attractive. It's not like "%X/%X" is > hard to type. > :). That's true. I thought LSN_FORMAT would document the string representation of an LSN. But anyway I am fine with this as well. > > -- > Peter Eisentraut > 2ndQuadrant, an EDB company > https://www.2ndquadrant.com/ > -- -- Best Wishes, Ashutosh
Commits
-
Simplify printing of LSNs
- 6f6f284c7ee4 14.0 landed
-
Unwind some workarounds for lack of portable int64 format specifier
- 6a1cd8b9236d 13.0 cited