Horton

Re: Allow specifying a dbname in pg_basebackup connection string

Jelte Fennema <me@jeltef.nl>

View thread View on postgr.es
From: Jelte Fennema <me@jeltef.nl>
To: Tristen Raab <tristen.raab@highgo.ca>
Cc: pgsql-hackers@lists.postgresql.org, Jelte Fennema <github-tech@jeltef.nl>
Date: 2023-08-29T13:55:05Z
Lists: pgsql-hackers

Attachments

On Mon, 28 Aug 2023 at 23:50, Tristen Raab <tristen.raab@highgo.ca> wrote:
> I've reviewed your patch and it applies and builds without error. When testing this patch I was slightly confused as to what its purpose was, after testing it I now understand. Initially, I thought this was a change to add database-level replication. I would suggest some clarifications to the documentation such as changing:

Thanks for the review. I've updated the documentation to make it
clearer (using some of your suggestions but also some others)

Commits

  1. pg_basebackup, pg_receivewal: fix failure to find password in ~/.pgpass.

  2. Allow dbname in pg_basebackup/pg_receivewal connstring