Re: [PATCH] Fix incorrect range in pg_regress comment
Jelte Fennema-Nio <postgres@jeltef.nl>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-02-02T21:46:55Z
Lists: pgsql-hackers
On Sun, 2 Feb 2025 at 22:26, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Hmm, our convention is definitely that the numbers start with 1, > so I do not want to make this change. Maybe we should change > the code instead. That would require any extensions that use the _0.out suffix to update all those files to use _1.out as the suffix. One such extension is Citus[1]. That seems like unnecessary extension churn with little benefit. So my vote would be to update the comment (as is done in patch v1). [1]: https://github.com/citusdata/citus/blob/main/src/test/regress/expected/columnar_lz4_0.out
Commits
-
Fix incorrect range in pg_regress comment.
- 43a15eb9400d 18.0 landed