Re: WIP Incremental JSON Parser
Jelte Fennema-Nio <postgres@jeltef.nl>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>, Amit Langote <amitlangote09@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-04-04T20:42:09Z
Lists: pgsql-hackers
On Thu, 4 Apr 2024 at 20:48, Jacob Champion <jacob.champion@enterprisedb.com> wrote: > > On Thu, Apr 4, 2024 at 11:12 AM Jacob Champion > <jacob.champion@enterprisedb.com> wrote: > > What's in the `...`? I wouldn't expect to find the test binary in your > > tmp_install. > > Oh, I wonder if this is just a build dependency thing? I typically run > a bare `ninja` right before testing, because I think most of those > dependencies are missing for the tests at the moment. (For example, if > I manually remove the `libpq_pipeline` executable and then try to run > `meson test` without a rebuild, it fails.) > > We can certainly fix that (see attached patch as a first draft) but I > wonder if there was a reason we decided not to during the Meson port? Yeah, that patch fixed my problem. (as well as running plain ninja) To clarify: I did do a rebuild. But it turns out that install-quiet doesn't build everything... The full command I was having problems with was: ninja -C build install-quiet && meson test -C build Maybe that's something worth addressing too. I expected that install/install-quiet was a strict superset of a plain ninja invocation.
Commits
-
Post review fixes for test_json_parser test module
- ba3e6e2bca97 17.0 landed
-
Shrink test file for test_json_parser module
- b8a7bfa33324 17.0 landed
-
Add support for incrementally parsing backup manifests
- ea7b4e9a2a7c 17.0 landed
-
Introduce a non-recursive JSON parser
- 3311ea86edc7 17.0 landed
-
Use incremental parsing of backup manifests.
- 222e11a10ae9 17.0 landed