Horton

Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx

Jelte Fennema-Nio <postgres@jeltef.nl>

View thread View on postgr.es
From: Jelte Fennema-Nio <postgres@jeltef.nl>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, Michael Paquier <michael@paquier.xyz>, Greg Sabino Mullane <htamfids@gmail.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-06-18T07:15:07Z
Lists: pgsql-hackers 
On Wed, 18 Jun 2025 at 08:23, Anthonin Bonnefoy
<anthonin.bonnefoy@datadoghq.com> wrote:
>
> On Tue, Jun 17, 2025 at 4:05 PM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> >
> > Agreed. My vote is for \closeprepared as that aligns with the libpq function.
>
> Since \bind_named is also new, we can also rename it to make it
> consistent with close meta-command. So what about renaming \bind_named
> to \bindprepared and \close to \closeprepared?

I think I still prefer \bind_named or maybe \bindnamed (depending on
what our policy for underscores in \ commands is). For that command it
should differentiate from the already existing \bind command, which is
also for prepared statements, just not for "named" prepared
statements. While close needs to differentiate from close for portals
vs close for prepared statements.

Commits

  1. psql: Rename meta-command \close to \close_prepared

  2. psql: Add tests for repeated calls of \bind[_named]

  3. psql: Fix memory leak with repeated calls of \bind

  4. psql: Clean up more aggressively state of \bind[_named], \parse and \close

  5. psql: Add more meta-commands able to use the extended protocol

  6. psql: Add ignore_slash_options in bind's inactive branch