Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

Jelte Fennema-Nio <me@jeltef.nl>

From: Jelte Fennema-Nio <me@jeltef.nl>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jacob Burroughs <jburroughs@instructure.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Dave Cramer <davecramer@gmail.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Pavel Stehule <pavel.stehule@gmail.com>, Jeff Davis <pgsql@j-davis.com>, Peter Eisentraut <peter@eisentraut.org>

Date: 2024-01-16T13:43:23Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

libpq: Add min/max_protocol_version connection options
- 285613c60a7a 18.0 landed
libpq: Handle NegotiateProtocolVersion message differently
- 5070349102af 18.0 landed
Add PQfullProtocolVersion() to surface the precise protocol version.
- cdb6b0fdb0b2 18.0 landed
Do not hardcode PG_PROTOCOL_LATEST in NegotiateProtocolVersion
- 516b87502dc1 18.0 landed
libpq: Handle NegotiateProtocolVersion message
- bbf9c282ce92 16.0 cited
Provide for forward compatibility with future minor protocol versions.
- ae65f6066dc3 11.0 cited

Attachments

v7-0005-Bump-protocol-version-to-3.1.patch (application/octet-stream) patch v7-0005
v7-0002-libpq-Handle-NegotiateProtocolVersion-message-mor.patch (application/octet-stream) patch v7-0002
v7-0003-Prepare-server-code-for-addition-of-protocol-exte.patch (application/octet-stream) patch v7-0003
v7-0001-libpq-Remove-instance-of-hardcoded-protocol-versi.patch (application/octet-stream) patch v7-0001
v7-0004-libpq-Include-minor-version-number-in-PQprotocolV.patch (application/octet-stream) patch v7-0004
v7-0008-psql-Warn-about-unsupported-protocol-features.patch (application/octet-stream) patch v7-0008
v7-0006-Add-protocol-message-to-change-parameters.patch (application/octet-stream) patch v7-0006
v7-0007-psql-Add-parameterset-meta-command.patch (application/octet-stream) patch v7-0007
v7-0009-Add-GUC-contexts-for-protocol-extensions.patch (application/octet-stream) patch v7-0009
v7-0010-Add-_pq_.protocol_managed_params-protocol-extensi.patch (application/octet-stream) patch v7-0010
v7-0011-Add-tests-for-ParameterSet-and-_pq_.protocol_mana.patch (application/octet-stream) patch v7-0011
v7-0012-Add-_pq_.report_parameters-protocol-extension.patch (application/octet-stream) patch v7-0012

On Thu, 11 Jan 2024 at 17:20, Jelte Fennema-Nio <me@jeltef.nl> wrote:
> So to be clear, if you consider 0008 the most controversial/risky part
> of this patchset (which it sounds like that's the case). I'd be fine
> with removing that for now.

I haven't removed 0008 yet, since I'd like some feedback first if that
makes sense. But I did add two new patches in the middle of the
patchset (which shift the later patch numbers by 2):

0007: Adds a new \parameterset meta-command to psql to be able to more
easily test the new ParameterSet message

0008: Shows warning in psql if the server is not supporting the newest
protocol version.