Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

Jelte Fennema-Nio <postgres@jeltef.nl>

From: Jelte Fennema <postgres@jeltef.nl>

To: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>

Cc: Jelte Fennema <Jelte.Fennema@microsoft.com>, Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut <peter@eisentraut.org>, Jacob Champion <jchampion@timescale.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, Justin Pryzby <pryzby@telsasoft.com>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2023-03-01T20:00:49Z

Lists: pgsql-hackers

Attachments

v13-0002-Refactor-libpq-to-store-addrinfo-in-a-libpq-owne.patch (application/x-patch) patch v13-0002
v13-0004-Add-non-blocking-version-of-PQcancel.patch (application/x-patch) patch v13-0004
v13-0003-Return-2-from-pqReadData-on-EOF.patch (application/x-patch) patch v13-0003
v13-0005-Start-using-new-libpq-cancel-APIs.patch (application/x-patch) patch v13-0005
v13-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch (application/x-patch) patch v13-0001

On Wed, 1 Mar 2023 at 20:51, Gregory Stark (as CFM) <stark.cfm@gmail.com> wrote:
> Great. Please update the CF entry to Needs Review or Ready for
> Committer as appropriate :)

I realised I rebased a slightly outdated version of my branch (thanks
to git its --force-with-lease flag). Attached is the newest version
rebased (only patch 0004 changed slightly).

And I updated the CF entry to Ready for Committer now.

Commits

postgres_fdw: re-issue cancel requests a few times if necessary.
- c431986de16c 18.0 landed
- 89962bfef624 17.3 landed
Make postgres_fdw's query_cancel test less flaky.
- 8749d850f962 17.0 landed
- 0e5c823806a3 18.0 landed
postgres_fdw: Split out the query_cancel test to its own file
- d329a515f490 17.0 landed
- 90c1ba52e06d 18.0 landed
Fix copy-paste mistake in PQcancelCreate
- 6d2ac554911d 17.0 landed
- 3497c87b05a6 18.0 landed
Make libpqsrv_cancel's return const char *, not char *
- b8b37e41ba4a 17.0 landed
Stabilize postgres_fdw test
- ecf741cfae06 17.0 landed
libpq-be-fe-helpers.h: wrap new cancel APIs
- 2466d6654f85 17.0 landed
dblink/isolationtester/fe_utils: Use new cancel API
- 66ab9371a233 17.0 landed
Put libpq_pipeline cancel test back
- 6b3678d3474f 17.0 landed
Hopefully make libpq_pipeline's new cancel test more reliable
- 1ee910ce4371 17.0 landed
libpq: Add encrypted and non-blocking query cancellation routines
- 61461a300c1c 17.0 landed
libpq: Move pg_cancel to fe-cancel.c
- 4dec98c2af64 17.0 landed
Add tests for libpq query cancellation APIs
- 319e9e53f379 17.0 landed
Add missing connection statuses to docs
- 095493a3771a 17.0 landed
libpq: Change some static functions to extern
- 774bcffe4a98 17.0 landed
libpq: Add pqReleaseConnHosts function
- 53747f722228 17.0 landed
libpq: Move cancellation related functions to fe-cancel.c
- 6d4565a05f3f 17.0 landed
Make spelling of cancelled/cancellation consistent
- 8c9da1441df1 17.0 landed
Be more wary about OpenSSL not setting errno on error.
- 0a5c46a7a488 17.0 cited
libpq: Use modern socket flags, if available.
- bfc9497ece01 16.0 cited
Drop test view when done with it.
- 71a75626d527 16.0 cited
Doc: add some doco about using the libpq_pipeline test module.
- f40346ff0bae 16.0 landed
postgres_fdw: Allow cancellation of transaction control commands.
- ae9bfc5d6512 10.0 cited