Re: psql not responding to SIGINT upon db reconnection

Jelte Fennema <postgres@jeltef.nl>

From: Jelte Fennema-Nio <postgres@jeltef.nl>

To: Tristan Partin <tristan@neon.tech>

Cc: Robert Haas <robertmhaas@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@postgresql.org, Shlok Kyal <shlok.kyal.oss@gmail.com>

Date: 2024-04-03T15:05:44Z

Lists: pgsql-hackers

Attachments

v13-0001-Fix-actually-reachable-pg_unreachable-call.patch (application/x-patch) patch v13-0001
v13-0002-Remove-PGRES_POLLING_ACTIVE-case.patch (application/x-patch) patch v13-0002

On Wed, 3 Apr 2024 at 16:55, Tristan Partin <tristan@neon.tech> wrote:
> Removing from the switch statement causes a warning:
>
> > [1/2] Compiling C object src/bin/psql/psql.p/command.c.o
> > ../src/bin/psql/command.c: In function ‘wait_until_connected’:
> > ../src/bin/psql/command.c:3803:17: warning: enumeration value ‘PGRES_POLLING_ACTIVE’ not handled in switch [-Wswitch]
> >  3803 |                 switch (PQconnectPoll(conn))
> >       |                 ^~~~~~


Ofcourse... fixed now

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix old, misleading comment for PGRES_POLLING_ACTIVE.
- e57fe3824ee7 17.0 landed
Remove reachable call to pg_unreachable().
- 12b964d7815b 17.0 landed
Allow SIGINT to cancel psql database reconnections.
- cafe1056558f 17.0 landed
Expose PQsocketPoll via libpq
- f5e4dedfa81f 17.0 landed
Fix query cancellation handling in psql
- 5d43c3c54d77 13.0 cited