Horton

Thread

Commits

  1. doc: Add missing values for meson options -Dcassert and -Db_coverage

  1. Add missing meson arguments in docs

    Jelte Fennema <me@jeltef.nl> — 2023-02-21T09:40:12Z

    The -Dcassert and -Db_coverage of the meson build didn't show in the
docs that they needed to be passed true or false. All other options
specified the arguments they expected. This patch fixes that.

  2. Re: Add missing meson arguments in docs

    Michael Paquier <michael@paquier.xyz> — 2023-02-22T01:57:47Z

    On Tue, Feb 21, 2023 at 10:40:12AM +0100, Jelte Fennema wrote:
> The -Dcassert and -Db_coverage of the meson build didn't show in the
> docs that they needed to be passed true or false. All other options
> specified the arguments they expected. This patch fixes that.

Indeed, values have to be specified after the equal sign of each
option, so applied what you are suggesting here.

-Db_coverage is part of the core options of meson because it is not
listed in meson_options.txt, no?  Documenting the switch is fine, but
it seems like we lack contents here.  The paragraph describing
-Db_coverage links to regress-coverage, still this only has
instructions for ./configure.  Shouldn't we have some docs to show one
how to achieve the same with meson?  I'd guess that a separate section
for meson would make the most sense, for as long as we support both
methods in parallel.

https://wiki.postgresql.org/wiki/Meson tells nothing about that, for
one.
--
Michael

  3. Re: Add missing meson arguments in docs

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2023-02-22T08:24:37Z

    On 22.02.23 02:57, Michael Paquier wrote:
> -Db_coverage is part of the core options of meson because it is not
> listed in meson_options.txt, no?  Documenting the switch is fine, but
> it seems like we lack contents here.  The paragraph describing
> -Db_coverage links to regress-coverage, still this only has
> instructions for ./configure.  Shouldn't we have some docs to show one
> how to achieve the same with meson?  I'd guess that a separate section
> for meson would make the most sense, for as long as we support both
> methods in parallel.

Yeah, this is just in the long tail of things to work through.

  4. Re: Add missing meson arguments in docs

    Michael Paquier <michael@paquier.xyz> — 2023-02-28T08:40:28Z

    On Wed, Feb 22, 2023 at 09:24:37AM +0100, Peter Eisentraut wrote:
> Yeah, this is just in the long tail of things to work through.

I am going through that, and found out what can be done to do coverage
reports.  I will post a patch separately on -hackers.
--
Michael