Re: Flushing large data immediately in pqcomm

Jelte Fennema-Nio <postgres@jeltef.nl>

From: Jelte Fennema-Nio <postgres@jeltef.nl>

To: David Rowley <dgrowleyml@gmail.com>

Cc: Andres Freund <andres@anarazel.de>, Melih Mutlu <m.melihmutlu@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>, Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, Ranier Vilela <ranier.vf@gmail.com>

Date: 2024-04-08T12:27:44Z

Lists: pgsql-hackers

Attachments

v9-0001-Make-a-few-variables-size_t-in-pqcomm.c.patch (application/octet-stream) patch v9-0001
v9-0002-Expand-comment-of-internal_flush_buffer.patch (application/octet-stream) patch v9-0002
v9-0003-Make-backend-libpq-write-functions-take-const-poi.patch (application/octet-stream) patch v9-0003

On Sun, 7 Apr 2024 at 11:34, David Rowley <dgrowleyml@gmail.com> wrote:
> That seems to require modifying the following function signatures:
> secure_write(), be_tls_write(), be_gssapi_write().  That's not an area
> I'm familiar with, however.

Attached is a new patchset where 0003 does exactly that. The only
place where we need to cast to non-const is for GSS, but that seems
fine (commit message has more details).

I also added patch 0002, which is a small addition to the function
comment of internal_flush_buffer that seemed useful to me to
differentiate it from internal_flush (feel free to ignore/rewrite).

Commits

Avoid needless large memcpys in libpq socket writing
- c4ab7da60617 17.0 landed