Re: Add trim_trailing_whitespace to editorconfig file

Jelte Fennema-Nio <postgres@jeltef.nl>

From: Jelte Fennema-Nio <postgres@jeltef.nl>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: Daniel Gustafsson <daniel@yesql.se>, Melanie Plageman <melanieplageman@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-02-15T17:47:45Z

Lists: pgsql-hackers

Attachments

v3-0002-Require-final-newline-in-.po-files.patch (application/octet-stream) patch v3-0002
v3-0004-Add-note-about-keeping-.editorconfig-and-.gitattr.patch (application/octet-stream) patch v3-0004
v3-0001-Remove-non-existing-file-from-.gitattributes.patch (application/octet-stream) patch v3-0001
v3-0005-Add-indent-information-about-gitattributes-to-edi.patch (application/octet-stream) patch v3-0005
v3-0003-Bring-editorconfig-in-line-with-gitattributes.patch (application/octet-stream) patch v3-0003

On Thu, 15 Feb 2024 at 16:57, Peter Eisentraut <peter@eisentraut.org> wrote:
> Is there a command-line tool to verify the syntax of .editorconfig and
> check compliance of existing files?
>
> I'm worried that expanding .editorconfig with detailed per-file rules
> will lead to a lot of mistakes and blind editing, if we don't have
> verification tooling.

I tried this one just now:
https://github.com/editorconfig-checker/editorconfig-checker.javascript

I fixed all the issues by updating my patchset to use "unset" for
insert_final_newline instead of "false".

All other files were already clean, which makes sense because the new
editorconfig rules are exactly the same as gitattributes (which I'm
guessing we are checking in CI/buildfarm). So I don't think it makes
sense to introduce another tool to check the same thing again.

Commits

Add script to keep .editorconfig in sync with .gitattributes
- 2452e71ff2fe 18.0 landed
Remove non-existing file from .gitattributes
- 1d577f2eaa88 15.7 landed
- 2c7f2eb0c8aa 16.3 landed
- e85732dac0e9 17.0 landed