Horton

Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()

Jelte Fennema <me@jeltef.nl>

View thread View on postgr.es
From: Jelte Fennema <me@jeltef.nl>
To: Jacob Champion <jchampion@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Michael Paquier <michael@paquier.xyz>
Date: 2023-02-16T11:31:46Z
Lists: pgsql-hackers 
Patch looks good to me. Definitely an improvement over the status quo.

Looking at the TLS error handling though I see these two lines:

&& conn->allow_ssl_try    /* redundant? */
&& !conn->wait_ssl_try) /* redundant? */

Are they actually redundant like the comment suggests? If so, we
should probably remove them (in another patch). If not (or if we don't
know), should we have these same checks for GSS?

Commits

  1. Fix inconsistent error handling for GSS encryption in PQconnectPoll()