Horton

Re: Add --check option to pgindent

Jelte Fennema-Nio <postgres@jeltef.nl>

View thread View on postgr.es
From: Jelte Fennema-Nio <postgres@jeltef.nl>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tristan Partin <tristan@neon.tech>, Andrew Dunstan <andrew@dunslane.net>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>, Euler Taveira <euler@eulerto.com>, Michael Banck <mbanck@gmx.net>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-12-18T16:15:59Z
Lists: pgsql-hackers 
On Mon, 18 Dec 2023 at 17:14, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> One thing I'm wondering: When both --check and --diff are passed,
> should pgindent still early exit with 2 on the first incorrectly
> formatted file? Or should it show diffs for all failing files? I'm
> leaning towards the latter making more sense.

To be clear, in the latter case it would still exit with 2 at the end
of the script, but only after showing diffs for all files.

Commits

  1. Rename pgindent options