Re: Improve readability by using designated initializers when possible

Jelte Fennema-Nio <postgres@jeltef.nl>

From: Jelte Fennema-Nio <postgres@jeltef.nl>

To: Michael Paquier <michael@paquier.xyz>

Cc: Japin Li <japinli@hotmail.com>, jian he <jian.universality@gmail.com>, Jeff Davis <pgsql@j-davis.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@lists.postgresql.org

Date: 2024-02-27T11:52:22Z

Lists: pgsql-hackers

Attachments

v3-0002-Use-designated-initializer-syntax-to-improve-read.patch (text/x-patch) patch v3-0002
v3-0003-Simplify-pg_enc2gettext_tbl.patch (text/x-patch) patch v3-0003

On Tue, 27 Feb 2024 at 07:25, Michael Paquier <michael@paquier.xyz> wrote:
> About 0002, I can't help but notice pg_enc2icu_tbl and
> pg_enc2gettext_tb.  There are exceptions like MULE_INTERNAL, but is it
> possible to do better?

Attached is an updated patchset to also convert pg_enc2icu_tbl and
pg_enc2gettext_tbl. I converted pg_enc2gettext_tbl in a separate
commit, because it actually requires some codechanges too.

Commits

Remove ObjectClass type
- 89e5ef7e2181 17.0 landed
Simplify pg_enc2gettext_tbl[] with C99-designated initializer syntax
- 655dc310460c 17.0 landed
Use C99-designated initializer syntax for arrays related to encodings
- ada87a4d95fc 17.0 landed
Remove last NULL element in config_group_names[]
- 48920476b490 17.0 landed
Use C99-designated initializer syntax for more arrays
- afd8ef39094b 17.0 landed
Remove unnecessary array object_classes[] in dependency.c
- ef5e2e90859a 17.0 landed
Add trailing commas to enum definitions
- 611806cd726f 17.0 cited